Add continuous scrolling for multi-page documents#699
Open
aljazceru wants to merge 1 commit into
Open
Conversation
aljazceru
force-pushed
the
continuous-scroll-upstream
branch
from
7798537 to
e38cae2
Compare
|
I tested your PR using app/src/androidTest/assets/test-multipage.pdf . There are panning issues when zoomed in when the viewer is at page 4 of the test pdf file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Large documents exposed two races in the continuous renderer. Repeated pinch events could queue enough WebView/JavaScript work to delay state reads, and a late-page jump could run before progressive page setup created the target wrapper. The scroll handler could then overwrite the requested page.
Zoom rendering now keeps one request in flight and coalesces pending updates. Page requests remain sticky until the target is laid out. Rendering and relayout are limited to the visible page window.
Validation
npm test -- --reporter=dot— 14 tests passednpx eslint ../gradlew :app:lintDebug :app:assembleDebug :app:assembleDebugAndroidTest --no-daemonANDROID_SERIAL=5A011JEBF06589 ./gradlew connectedDebugAndroidTest --no-daemon— 77 tests passed on a Pixel 9agit diff --check